Skip to content
This repository was archived by the owner on Apr 17, 2019. It is now read-only.

Add option to load peers from a file on startup - #2232

Open
luckychess wants to merge 1 commit into
developfrom
feature/peers_from_file
Open

luckychess wants to merge 1 commit into
developfrom
feature/peers_from_file

Conversation

@luckychess

Copy link
Copy Markdown
Contributor

Description of the Change

Pull request adds command line option to load peers list from a file on startup.

Benefits

It could be useful in scenarios when many peers in a current network state are malicious.

Possible Drawbacks

  • Usage of a potentially deprecated PostgresWsvCommand class
  • Lack of tests for PeersFileReaderImpl (not sure should I add add them or not)

Usage Examples or Tests

Create file peers with line 127.0.0.1:10001 bddd58404d1315e0eb27902c5d7c8eb0602c16238f005773df406bc191308929 (feel free to add more peers) and
run irohad with option --peers peers

Signed-off-by: Konstantin Munichev <toobwn@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant