Everything ifc

CHANGELOG.md

@@ -19,6 +19,7 @@
 - `Message.Info`
 - `Message.Error`
 - `Message.Warning`
+- `BuildingElement`
 
 ### Changed
 
@@ -527,6 +528,9 @@
 - `Vector3.>=`
 - `Vector3.<=`
 - `Plane.Intersects(Plane a, Plane b)`
+
+### Removed
+- `IHasOpenings`
 - A handful of convenience operators and conversions:
   - implicit `(double X, double Y, double Z)` => `Vector3`
   - implicit `(double X, double Y)` => `Vector3`

Elements.Serialization.IFC/src/Elements.Serialization.IFC.csproj

@@ -16,7 +16,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Hypar.IFC4" Version="0.1.4.1" />
+    <PackageReference Include="Hypar.IFC4" Version="1.0.0" />
   </ItemGroup>
 
   <ItemGroup>

Elements.Serialization.IFC/src/Serialization/IFC/IFCElementExtensions.cs

@@ -4,7 +4,6 @@
 using Elements.Geometry;
 using Elements.Geometry.Interfaces;
 using Elements.Geometry.Solids;
-using Elements.Interfaces;
 using IFC;
 
 namespace Elements.Serialization.IFC
@@ -169,19 +168,17 @@ internal static List<IfcProduct> ToIfcProducts(this Element e,
 
             // If the element has openings, make opening relationships in
             // the IfcElement.
-            if (e is IHasOpenings openings)
+            if (geoElement is BuildingElement)
             {
-                if (openings.Openings.Count > 0)
+                var be = geoElement as BuildingElement;
+                foreach (var o in be.Openings)
                 {
-                    foreach (var o in openings.Openings)
-                    {
-                        var element = (IfcElement)product;
-                        // TODO: Find the opening that we've already created that relates here
-                        var opening = ifcOpenings.First(ifcO => ifcO.GlobalId == IfcGuid.ToIfcGuid(o.Id));
-                        var voidRel = new IfcRelVoidsElement(IfcGuid.ToIfcGuid(Guid.NewGuid()), element, opening);
-                        element.HasOpenings.Add(voidRel);
-                        doc.AddEntity(voidRel);
-                    }
+                    var element = (IfcElement)product;
+                    // TODO: Find the opening that we've already created that relates here
+                    var opening = ifcOpenings.First(ifcO => ifcO.GlobalId == IfcGuid.ToIfcGuid(o.Id));
+                    var voidRel = new IfcRelVoidsElement(IfcGuid.ToIfcGuid(Guid.NewGuid()), element, opening);
+                    element.HasOpenings.Add(voidRel);
+                    doc.AddEntity(voidRel);
                 }
             }