Skip to content

Enforce 100% type coverage in CI with Pyrefly - #831

Merged
hynek merged 2 commits into
hynek:mainfrom
jorenham:ci/pyrefly-coverage-check
Jul 27, 2026
Merged

Enforce 100% type coverage in CI with Pyrefly#831
hynek merged 2 commits into
hynek:mainfrom
jorenham:ci/pyrefly-coverage-check

Conversation

@jorenham

Copy link
Copy Markdown
Contributor

Summary

Following #828 (comment), this ensures that the public API type coverage is kept at 100% by running pyrefly coverage check in CI.

There should be no need to route this through tox, because pyrefly already supports uvx natively.

Pull Request Checklist

  • I acknowledge this project's AI policy.
  • This pull request is not from my main branch.
  • There's tests for all new and changed code.
  • New APIs are added to our typing tests in api.py.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
      • The next version is the second number in the current release + 1. The first number represents the current year. So if the current version on PyPI is 26.1.0, the next version is gonna be 26.2.0. If the next version is the first in the new year, it'll be 27.1.0.
  • Documentation in .rst and .md files is written using semantic newlines.
  • Changes (and possible deprecations) are documented in the changelog.

@hynek hynek left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no need to route this through tox, because pyrefly already supports uvx natively.

That is true, but I try to have everything that needs to pass offline too with online/offline parity, such that pushing a passing tox has good chances to pass in CI too.

Just add it to the existing pyrefly tox env and call it a day – thanks!

@hynek
hynek merged commit 6651ae6 into hynek:main Jul 27, 2026
18 checks passed
@hynek

hynek commented Jul 27, 2026

Copy link
Copy Markdown
Owner

sweet, thanks!

@jorenham
jorenham deleted the ci/pyrefly-coverage-check branch July 27, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants