Enforce 100% type coverage in CI with Pyrefly - #831
Merged
Conversation
hynek
requested changes
Jul 27, 2026
hynek
left a comment
Owner
There was a problem hiding this comment.
There should be no need to route this through tox, because pyrefly already supports uvx natively.
That is true, but I try to have everything that needs to pass offline too with online/offline parity, such that pushing a passing tox has good chances to pass in CI too.
Just add it to the existing pyrefly tox env and call it a day – thanks!
Owner
|
sweet, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following #828 (comment), this ensures that the public API type coverage is kept at 100% by running
pyrefly coverage checkin CI.There should be no need to route this through tox, because
pyreflyalready supportsuvxnatively.Pull Request Checklist
mainbranch.api.py.docs/api.rstby hand.versionadded,versionchanged, ordeprecateddirectives..rstand.mdfiles is written using semantic newlines.