Fix min_laser_range from SLAM - #8
Open
a-eldesouky wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the min_laser_range setting in the SLAM configuration for Rosbot 2 Pro. Previously, the parameter was set to 0.0m, which is below the minimum range of the Lidar sensor (0.2m). This caused the following warning during SLAM initialization:
Testing:
Tested on Rosbot 2 Pro.
Verified that SLAM initializes without warnings.
Confirmed normal mapping functionality.
Notes:
Please review and let me know if any further modifications are needed!
Thanks for maintaining this repo and supporting the community