Add skip_origin_metadata flag to optimize streaming startup time#8291
Open
yuxin00j wants to merge 3 commits into
Open
Add skip_origin_metadata flag to optimize streaming startup time#8291yuxin00j wants to merge 3 commits into
skip_origin_metadata flag to optimize streaming startup time#8291yuxin00j wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8197.
When streaming datasets that consist of many remote data files, the initial origin metadata fetch (
_get_origin_metadatawhich queries ETag/mtime) can become a significant latency bottleneck.This PR implements the accepted feature request to introduce an optional
skip_origin_metadatakeyword argument to bypass these checks and improve streaming startup time.Changes:
skip_origin_metadata: bool = FalsetoDatasetBuilder.__init__and data resolution methods acrossDataFilesListandDataFilesDict.skip_origin_metadata=True, pattern resolution assigns empty tuple placeholders[()] * len(data_files)rather than making expensive network/filesystem calls.FileNotFoundError.load_dataset: this optimization is strictly intended for streaming mode. Ifskip_origin_metadata=Trueis passed alongsidestreaming=False, a warning is logged and the flag is safely forced back toFalse.tests/test_data_files.pyandtests/test_load.pyto ensure correct behavior and error handling.