fix(json): write valid JSON array when lines=False with batching#8275
Open
KirtiRamchandani wants to merge 1 commit into
Open
fix(json): write valid JSON array when lines=False with batching#8275KirtiRamchandani wants to merge 1 commit into
KirtiRamchandani wants to merge 1 commit into
Conversation
Batched exports with lines=False previously wrote multiple top-level JSON arrays back-to-back, producing invalid JSON for datasets larger than batch_size. Merge batch outputs into a single array for orient=records. Fixes huggingface#7037
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dataset.to_json(lines=False, orient="records")when the dataset is larger thanbatch_size[...][...]), producing invalid JSON (JSONDecodeError: Extra data)Fixes #7037
Test plan
pytest tests/io/test_json.py::TestJsonDatasetWriter::test_dataset_to_json_records_batched_without_linespytest tests/io/test_json.py::TestJsonDatasetWriter::test_dataset_to_json_lines tests/io/test_json.py::TestJsonDatasetWriter::test_dataset_to_json_orient/cc @albertvillanova