Skip to content

refactor: streamline VirtualScrollContainer component and update task handling #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
damianpumar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: streamline VirtualScrollContainer component and update task handling #446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/components/ui/virtual-scroll/virtual-scroll.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,20 @@
import {
$,
component$,
Fragment,
type HTMLAttributes,
type QRL,
type Signal,
component$,
useSignal,
useTask$,
useVisibleTask$,
} from '@builder.io/qwik';
import { isBrowser } from '@builder.io/qwik/build';
import {
type VirtualItem,
Virtualizer,
elementScroll,
observeElementOffset,
observeElementRect,
type VirtualItem,
Virtualizer,
} from '@tanstack/virtual-core';
import { nextTick } from '~/components/hooks/tick';
import { makeSerializable } from './make-serializable';
Expand Down Expand Up @@ -73,9 +72,9 @@ export const VirtualScrollContainer = component$(
itemRenderer,
scrollElement,
estimateSize,
overscan,
pageSize = 10,
buffer = 3,
overscan = 1,
pageSize = 1,
buffer = 1,
debug = false,
}: {
totalCount: number;
Expand Down Expand Up @@ -133,7 +132,7 @@ export const VirtualScrollContainer = component$(
}
});

useVisibleTask$(({ track }) => {
useTask$(({ track }) => {
track(scrollElement);

if (!virtualState.value) {
Expand All @@ -142,7 +141,7 @@ export const VirtualScrollContainer = component$(
});

const visibleRows = useSignal<VirtualItem[]>([]);
useVisibleTask$(({ track }) => {
useTask$(({ track }) => {
track(() => virtualState.state.range);
if (!virtualState.value) return;

Expand Down
Loading