feat(activesync): add optional Sync TruncationSize ceiling - #96
Draft
TDannhauer wants to merge 1 commit into
Draft
feat(activesync): add optional Sync TruncationSize ceiling#96TDannhauer wants to merge 1 commit into
TDannhauer wants to merge 1 commit into
Conversation
This was referenced Jul 26, 2026
🔍 CI ResultsOverall: ❌ 12/12 lanes failed TL;DR: ❌ Quality issues: PHPStan: 243 unique errors in 11 lanes; PHP-CS-Fixer: 31 files. Summary by PHP Version
Quality Metrics
❌ Failed Lanesphp8.0-dev
php8.0-stable
php8.1-dev
php8.1-stable
php8.2-dev
php8.2-stable
php8.3-dev
php8.3-stable
php8.4-dev
php8.4-stable
php8.5-dev
php8.5-stable
CI powered by horde-components • View full results |
TDannhauer
marked this pull request as draft
July 26, 2026 13:18
TDannhauer
force-pushed
the
feat/maximum-truncation-size
branch
from
July 29, 2026 08:34
b0674eb to
bcc6161
Compare
Allow admins to cap client BodyPreference TruncationSize during Sync (0 = honor client), without affecting ItemOperations Fetch.
TDannhauer
force-pushed
the
feat/maximum-truncation-size
branch
from
July 30, 2026 11:30
97e1b7d to
624c4fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$conf['activesync']['sync']['maximumtruncationsize'](default0= honor client) that caps Sync-exportBodyPreference/ MIME truncation only.Motivation
Follows the same admin override pattern as
maximumwindowsize. Investigation in #88 showed Gmail never re-fetches truncated bodies, while Nine and iOS do — so this knob is a bandwidth / completeness trade-off. Keep-or-drop is pending maintainer input on #88; this PR stays open for that verdict.Related
BINARY.SIZE/EstimatedDataSizefix and client behaviour docs moved to fix(activesync): ignore bogus BINARY.SIZE; document client truncation #98 (no longer bundled here).Test plan
TruncationCapTestunit coverage for cap / zero-means-unlimited semantics0, Sync honours client TruncationSize; with a positive cap, Sync exports are clamped; ItemOperations mailbox Fetch still returns full body