feat: implement filter functionality#169
Open
crfmc wants to merge 87 commits into
Open
Conversation
crfmc
commented
Dec 23, 2025
Collaborator
- Add filtering interface from configuration file
- feat: update file upload styles and icons - refactor: move components out of app.tsx
- feat: implement cohort selection
- feat: update default names of cohorts - refactor: remove useMemo call
- feat: allow array format for file upload
- feat: add url param for cohortId
- feat: enable proper file renaming
- feat: add placeholder error banner for malformed external url - feat: when users upload cohort, switch to the first samples - refactor: reorganize components/files
- feat: update validation for uploaded files - feat: implement better error banners - refactor: improve helper functions
- fix: un-nest all CSS declarations - feat: warning banner when external demo fails
- feat: adjust text for upload url button - style: update colors and spacing
- style: update navigation bar styles for safari
- style: adjust spacing
- feat: update text - feat: use file name as default
|
New Issues (81)Checkmarx found the following issues in this Pull Request
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
Use @Checkmarx to interact with Checkmarx PR Assistant. |
- feat: utils for checking type and accessing nested field - feat: template for binary filter
- refactor: remove unused variables - refactor: update typing
- refactor: unused file
sehilyi
reviewed
Jun 23, 2026
Comment on lines
+39
to
+45
| filters: [ | ||
| { | ||
| field: 'cancer', | ||
| title: 'Cancer Type', | ||
| type: 'string' | ||
| } | ||
| ], |
Member
There was a problem hiding this comment.
Here is a type error. I wonder if this should be the following instead:
Suggested change
| filters: [ | |
| { | |
| field: 'cancer', | |
| title: 'Cancer Type', | |
| type: 'string' | |
| } | |
| ], | |
| filters: { | |
| cancer_type: { | |
| field: 'cancer', | |
| title: 'Cancer Type', | |
| type: 'string' | |
| } | |
| }, |
Given how it is defined:
export type Cohort = {
name?: string;
samples: any;
filters?: { [key: string]: CohortFilter };
};
sehilyi
reviewed
Jun 23, 2026
| name: formattedDataName, | ||
| samples: formattedDataSamples | ||
| samples: formattedDataSamples, | ||
| filters: data.filters ?? [] |
Member
There was a problem hiding this comment.
I think it should be an object?
Suggested change
| filters: data.filters ?? [] | |
| filters: data.filters ?? {} |
Collaborator
|
Sehi found 2 critical issues:
|
- fix: type errors - fix: reset filters when cohort changes
- refactor: update keyboard navigation
- fix: update range values when showing as chips - fix: add early return when dropdown doesn't exists
feat: open clinical panel by default
- fix: support negative values for bins using regex - fix: use forEach for filter identifiers
- fix: add guards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




