Skip to content

🌱 ci: stop persisting checkout credentials in PR-tree workflows #17682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clubanderson wants to merge 1 commit into
base: v5
Choose a base branch
from
+9 −0
Open

🌱 ci: stop persisting checkout credentials in PR-tree workflows #17682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci-runner-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

# Resolve the base image and the tag once, up front, so every later step
# (the exists-check, the build, the summary) agrees on them.
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/docs-index-reminder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ jobs:
timeout-minutes: 10
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- name: Find docs added by this PR that the index does not link
id: check
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/mutation-advisory.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
fetch-depth: 0
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/pr-overlap.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
fetch-depth: 0
# Hermetic (local repos + gh double), under a second: a broken check
# mislabels every open PR, so it must not ship untested (#9319).
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/stream-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

# The supervisor scripts have no Go test lane; shellcheck them and run
# the watchdog decision tests (fake ffmpeg, stubbed Twitch check) here,
Expand Down
1 change: 1 addition & 0 deletions src/changelog.d/changed-checkout-no-persist-credentials.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- CI: the `pull_request` workflows `mutation-advisory`, `pr-overlap`, `stream-image`, `ci-runner-image` and `docs-index-reminder` now check out with `persist-credentials: false`. None of those jobs pushes or fetches with the job token; steps that call the API keep getting it through their step `env`, scoped by the job's `permissions:` block (#17636).
Loading