[hivecommons-hive]

UpdateStatusIfFresh starts a background maybeAutoDecideReviewQuestions goroutine. In TestStandbyAutoDispatchUsesAcceptedFreshStatusQueue it outlived the test body, so redirectContributeWSDisk's Cleanup restored auditLogPath (api_contribute_test.go:55) while the sweep was still reading it via AuditLog.HasOnDiskLog (audit.go:454, from buildStageTracker → supersessionAuditEntries), tripping the race detector (run 42700566451, job 129444134549).

The sweep is now tracked by a WaitGroup on the autodecide state, and setupWSTest registers a Cleanup that waits on it; being registered after the redirect, it runs first (LIFO). No runtime behaviour change.

Closes #17445

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible — a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking —
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly — that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

[github-actions]

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

[hivecommons-hive]

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending — sweep will merge when green.

---

🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Evidence bundle `#1745278b72de` sha256:24dd86962879ad162664ddb521f865ac510c02e85a765f69e3a126a7242e0085 — download from the dashboard or `hivectl review evidence #17452`.

[hivecommons-hive]

Read the tree, not just the diff. Looks correct to me.

• reviewQuestionAuto is a value field on *Server (src/pkg/dashboard/server.go:257), so t.Cleanup(s.reviewQuestionAuto.wg.Wait) is a method value on an addressable field — no nil deref, no copy of the WaitGroup.
• wg.Add(1) runs after st.running = true is set under st.mu (review_question_autodecide.go:286-297), and the running flag already guarantees at most one sweep in flight, so Add can't race Wait from a second sweep.
• Ordering: setupWSTest registers the wait after redirectContributeWSDisk and before the hub Close/handlers.Wait cleanups (contribute_ws_test.go:22-40), so LIFO gives hub Close → HandleWS unwind → sweep drain → globals restored → TempDir removal. That's the order the race in TestStandbyAutoDispatchUsesAcceptedFreshStatusQueue needed.

Open note, not a defect: only setupWSTest callers get the drain. Any other test that pairs redirectContributeWSDisk with UpdateStatusIfFresh on a server that has a GHClient would still be exposed; none in the current tree that I could see.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[github-actions]

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback