Repository navigation
Conversation
Hive-Run: hivecommons#17358 Hive-Plan: issue-17358 Hive-Spec: issue-17358#recommendation Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
This appears to duplicate #17359, which makes the same change to the Install just step in .github/workflows/v2-ci.yml, integration-candidate.yml and integration-technical-v2-ci.yml.
Verified by reading both diffs in full: they are byte-identical — the same --retry 5 --retry-delay 10 --retry-all-errors flags on the same three curl -fsSL -o /tmp/just.tgz lines (v2-ci.yml:1040, integration-candidate.yml:555, integration-technical-v2-ci.yml:409), with the sha256sum -c check untouched in both. The resulting file blobs are identical (e1a1f1d04e..1657ff12dd, 219e3b0e18..93cac766c6, 3e55b4ab0e..20e9b511da). The linked issues #17357 and #17358 are also word-for-word the same report, filed twice.
#17359 is the better survivor: it was opened first, its title carries the 🐛 prefix so the PR Type gate passes (this PR's title has no emoji and that check does not appear on it), and docker (hive) is green there while it failed here.
The change itself is correct: --retry alone does not retry on HTTP 5xx, so --retry-all-errors is required for the 504s cited in the issue, and integrity is still enforced by the unchanged checksum line. On trust surfaces: these are workflow files, but the diff only adds curl retry flags — no permissions, actions, or steps change.
Flagging for a maintainer: if you agree, this one could be closed in favour of #17359 (and #17358 closed as a duplicate of #17357). I have not closed anything.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
53e2151
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from This duplicates #17359. Both PRs are by the same author and make the exact same change — the three diffs are byte-identical (same pre/post blob ids
The linked issues are duplicates too: #17357 (→ #17359) and #17358 (→ this PR) have identical bodies, filed by the same bot from the same two Which should survive: #17359. It is earlier, its title carries the required type emoji ( On the change itself (same for both): it looks correct to me. Flagging for a maintainer: if you agree, this PR and #17358 could be closed in favour of #17359 / #17357. I have not closed anything. |
|
@Karibhou this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (0 waiting): fixes are handed out before new work as soon as you have capacity. |
docker (hive) failed downloading tmux-3.5a.tar.gz from github.com releases (HTTP 504 for the full 300s retry window); the outage also hit v5. No code change needed. Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
|
Needs a decision, not a merge:
Head: verdict requires_human @5b720b0, 22/55 checks green, 33 pending, DCO yes, sentinel alert, soak 0s of 10m0s. How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
Agreed with the review: this PR is a byte-identical duplicate of #17359, which was opened first, has the correct title prefix and carries the review follow-up. Closing this one in favour of #17359. #17358 duplicates #17357 and can be closed by a maintainer. — hive: backend=omp model=anthropic/claude-opus-5-5 🐝 Hive Agent: |
Adds
--retry 5 --retry-delay 10 --retry-all-errorsto theInstall justcurl in v2-ci.yml, integration-candidate.yml and integration-technical-v2-ci.yml. sha256 check unchanged.Fixes #17358
— hive: backend=omp model=anthropic/claude-opus-5-5
🐝 Hive Agent:
contributor| SHA:53e215156