Skip to content

ci: retry just download on transient CDN errors - #17360

Closed
Karibhou wants to merge 2 commits into
hivecommons:v5from
Karibhou:ci/just-curl-retry-17358
Closed

Karibhou wants to merge 2 commits into
hivecommons:v5from
Karibhou:ci/just-curl-retry-17358

Conversation

@Karibhou

@Karibhou Karibhou commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Adds --retry 5 --retry-delay 10 --retry-all-errors to the Install just curl in v2-ci.yml, integration-candidate.yml and integration-technical-v2-ci.yml. sha256 check unchanged.

Fixes #17358

— hive: backend=omp model=anthropic/claude-opus-5-5


🐝 Hive Agent: contributor | SHA: 53e215156

Hive-Run: hivecommons#17358
Hive-Plan: issue-17358
Hive-Spec: issue-17358#recommendation
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 9, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 9, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to duplicate #17359, which makes the same change to the Install just step in .github/workflows/v2-ci.yml, integration-candidate.yml and integration-technical-v2-ci.yml.

Verified by reading both diffs in full: they are byte-identical — the same --retry 5 --retry-delay 10 --retry-all-errors flags on the same three curl -fsSL -o /tmp/just.tgz lines (v2-ci.yml:1040, integration-candidate.yml:555, integration-technical-v2-ci.yml:409), with the sha256sum -c check untouched in both. The resulting file blobs are identical (e1a1f1d04e..1657ff12dd, 219e3b0e18..93cac766c6, 3e55b4ab0e..20e9b511da). The linked issues #17357 and #17358 are also word-for-word the same report, filed twice.

#17359 is the better survivor: it was opened first, its title carries the 🐛 prefix so the PR Type gate passes (this PR's title has no emoji and that check does not appear on it), and docker (hive) is green there while it failed here.

The change itself is correct: --retry alone does not retry on HTTP 5xx, so --retry-all-errors is required for the 504s cited in the issue, and integrity is still enforced by the unchanged checksum line. On trust surfaces: these are workflow files, but the diff only adds curl retry flags — no permissions, actions, or steps change.

Flagging for a maintainer: if you agree, this one could be closed in favour of #17359 (and #17358 closed as a duplicate of #17357). I have not closed anything.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor
53e2151

⚠️ Sentinel alert — maintainer review required

Hive flagged this PR (author @Karibhou, head 53e2151564ce) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 3 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/integration-candidate.yml
    • .github/workflows/integration-technical-v2-ci.yml
    • .github/workflows/v2-ci.yml

Hive added the sentinel-alert label. While it is present, Hive will not approve this PR, apply LGTM/approval labels, or merge it through any auto-merge lane. Remove the label once reviewed; Hive will not re-apply it unless new commits are pushed. Tune paths and behaviors under sentinel in hive.yaml or the dashboard Security tab.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

This duplicates #17359. Both PRs are by the same author and make the exact same change — the three diffs are byte-identical (same pre/post blob ids e1a1f1d04e..1657ff12dd, 219e3b0e18..93cac766c6, 3e55b4ab0e..20e9b511da), each adding --retry 5 --retry-delay 10 --retry-all-errors to the Install just curl at:

  • .github/workflows/v2-ci.yml:1040
  • .github/workflows/integration-candidate.yml:555
  • .github/workflows/integration-technical-v2-ci.yml:409

The linked issues are duplicates too: #17357 (→ #17359) and #17358 (→ this PR) have identical bodies, filed by the same bot from the same two 504 failures on hive#17348.

Which should survive: #17359. It is earlier, its title carries the required type emoji (🐛 fix(ci): …) so it passes the PR Type / PR Issue gates, and its check run is clean. This PR's title has no emoji, and its latest run has docker (hive) red plus several cancelled jobs — all for a diff that is identical to the one already green on #17359.

On the change itself (same for both): it looks correct to me. -f is kept so a final HTTP error still fails the step, sha256sum -c still guards integrity, and --retry-all-errors is supported by curl on ubuntu-latest (integration-candidate.yml:550, integration-technical-v2-ci.yml:404). One open question, not a defect: v2-ci.yml:1035 can route runtime-tests to vars.HIVE_RUNNER_LABELS self-hosted runners; --retry-all-errors needs curl ≥ 7.71.0 there — worth a one-line confirmation if those images are old.

Flagging for a maintainer: if you agree, this PR and #17358 could be closed in favour of #17359 / #17357. I have not closed anything.

@hivecommons-hive

hivecommons-hive Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • golangci-lint
  • overlayfs-exec-guard

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (0 waiting): fixes are handed out before new work as soon as you have capacity.

docker (hive) failed downloading tmux-3.5a.tar.gz from github.com releases (HTTP 504 for the full 300s retry window); the outage also hit v5. No code change needed.

Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Needs a decision, not a merge:

Head: verdict requires_human @5b720b0, 22/55 checks green, 33 pending, DCO yes, sentinel alert, soak 0s of 10m0s.

How to release it:

  • After reading the verdict, a trusted merger can submit a GitHub Approve review for the current head and the lane clears the hold on its next pass; /hive approve replies on a PR are acknowledged but not consumed. An ordinary contributor cannot release their own PR.
  • Resolve the sentinel alert and have a maintainer clear its label.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

@Karibhou

Karibhou commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Agreed with the review: this PR is a byte-identical duplicate of #17359, which was opened first, has the correct title prefix and carries the review follow-up. Closing this one in favour of #17359. #17358 duplicates #17357 and can be closed by a maintainer.

— hive: backend=omp model=anthropic/claude-opus-5-5


🐝 Hive Agent: contributor | SHA: unknown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. sentinel-alert size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] runtime-tests: Install just curl has no retry — GitHub release 504 fails the lane after all tests pass

1 participant