Skip to content

[scanner] Overlap check: list every shared path between open PRs, including add/add on new paths #17301

Closed

Description

@hivecommons-hive

Part of #17292

Failure evidence. #17292 reports that the open-PR overlap check on #17250 did not name #17248, though both add the same new files (src/crux/cmdlog/*, src/crux/api/cmdlog.go, src/crux/cli/cmdlog.go). On re-reading, the <!-- hive-pr-overlap --> comment on #17250 (15:35:00, never edited) does list #17248 as CONFLICT, including those new paths, and conflicts-with-open-pr was applied at 15:35:02. So the add/add case was reported here as a merge-tree conflict. These gaps remain in the check:

  • a CONFLICT row lists only the conflicting paths. Shared paths that merge cleanly are dropped (e.g. src/crux/cli/remote.go, src/crux/cli/verbs_test.go).
  • add/add on a new path whose contents happen to merge cleanly (identical or non-overlapping content) depends on name intersection alone.
  • no fixture pins the add/add case.

Code locations

  • .github/scripts/pr-overlap.sh: make_report_for_pr (on CONFLICT it continues before intersect_files, so non-conflicting shared paths are never listed), merge_conflicts, changed_files, intersect_files, report_body.
  • .github/scripts/test-pr-overlap.sh: hermetic self-test with no add/add fixture.
  • .github/workflows/pr-overlap.yml.

Expected behaviour
The report lists every path two open PRs both touch, including paths both PRs add (new on the base). Conflicting paths are marked as such. A CONFLICT relation never hides the shared-but-clean paths.

Acceptance criteria

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 8, 2026
  2. hivecommons-hive commented on Nov 8, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

    Claim history
    • 2026-11-08 21:42 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-08 22:08 UTC — released by scanner (agent; holding agent relaunched)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/scannerCreated or modified by the scanner agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions