Repository navigation
fix: include the PoX sunset burn in mainnet staking reward totals - #2709
Merged
Merged
Conversation
rafa-stacks
changed the title
rafa-stacks
marked this pull request as ready for review
October 7, 2026 04:15
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The surcharge is applied before its historical period is ingested, and the public schema still documents its exclusion.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds the historical PoX sunset burn surcharge to mainnet staking reward totals.
Changes:
- Adds 489,352,064 sats to mainnet burn and total amounts.
- Adds mainnet-specific endpoint coverage.
| File | Description |
|---|---|
src/api/routes/v3/staking-rewards.ts |
Applies the mainnet surcharge. |
tests/api/burnchain/staking-rewards.test.ts |
Tests adjusted mainnet totals. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
fabrizio-stacks
approved these changes
Oct 7, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /extended/v3/staking/rewardsleft out the 2.0-era PoX sunset-ramp surcharge (bitcoin blocks ~766050-781551) fromburn_amount, because the node never reported those burns in its/new_burn_blockevents. This PR adds a fixed historical total of 489352064 sats toburn_amount, and so tototal_amount, on mainnet only.