[WIP] [Padrino] バージョンアップ (0.14.3まで) - #7
Open
phamvanhungmixi wants to merge 883 commits into
Open
Conversation
Fix quote in controller generator template.
…_fix Only output a warning message if the spec task is invoked.
Thread.exclusive has deprecated in Ruby 2.3. See: http://mla.n-z.jp/~w3ml/w3ml.cgi/ruby-changes/msg/40473
Use Ruby 2.3.0 on travis
Thread.exclusive -> Mutex
Not 100% sure this is the right link, but there is a faq there, and the old link was to nowhere
Padrino-gen now properly fails with NameError when provided with erroneous controller, helper, mailer, migration, task name.
Assuming this method exists breaks the usage of the router in non-Padrino applications, such as the standalone Sinatra example listed on the website.
Very small changes from 0.8.1 https://github.com/minad/moneta/blob/master/CHANGES
Fixes instances of "NameError: uninitialized constant Utils"
Test that ActiveRecord::Migration responds to .[] before using .current_version, as .current_version is used in previous versions but for different purposes.
Add codetriage badge for Padrino
Allow array as html attribute
…clause to not initialize @params if already defined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題
https://github.com/hirocaster/padrino-framework/blob/template-pager/.travis.yml
0.12.3はruby2.1までしかサポートしてなさそうです。
解決
今後Rubyバージョンアップするため、padrino-frameworkをバージョンアップしてみます。
その他
(0.14.3ではconfigがrollback対象外なので、中途半端なロードしなくると思います padrino/padrino-framework@843e474)
https://github.com/phamvanhung2e123/my_padrino_projectは0.14.3で中途半端なロードじゃなくて、落ちます。