chore: remove SelfSerializable from NodeId - #26805
Open
abies wants to merge 3 commits into
Open
Conversation
Signed-off-by: Artur Biesiadowski <artur.biesiadowski@swirldslabs.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: Artur Biesiadowski <artur.biesiadowski@swirldslabs.com>
Signed-off-by: Artur Biesiadowski <artur.biesiadowski@swirldslabs.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #26805 +/- ##
============================================
+ Coverage 70.45% 70.47% +0.01%
+ Complexity 11674 11672 -2
============================================
Files 2582 2582
Lines 108331 108316 -15
Branches 12117 12114 -3
============================================
+ Hits 76330 76332 +2
+ Misses 28017 27998 -19
- Partials 3984 3986 +2
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
✅ All tests passed ✅🏷️ Commit: fd0ee6e Learn more about TestLens at testlens.app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Part of the bigger task of getting rid of SelfSerialiable. NodeId had the issue with slightly wrong deserialization, so removing it early helps with buggy node scans.
Related issue(s):
Fixes #26756
Checklist