Skip to content

chore: remove SelfSerializable from NodeId - #26805

Open
abies wants to merge 3 commits into
mainfrom
26756-remove-selfserializable-nodeid
Open

chore: remove SelfSerializable from NodeId#26805
abies wants to merge 3 commits into
mainfrom
26756-remove-selfserializable-nodeid

Conversation

@abies

@abies abies commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Description:
Part of the bigger task of getting rid of SelfSerialiable. NodeId had the issue with slightly wrong deserialization, so removing it early helps with buggy node scans.

Related issue(s):

Fixes #26756

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Artur Biesiadowski <artur.biesiadowski@swirldslabs.com>
@abies abies added this to the v0.79 milestone Aug 12, 2026
@abies abies self-assigned this Aug 12, 2026
@abies
abies requested a review from a team as a code owner August 12, 2026 13:12
@abies
abies requested a review from timo0 August 12, 2026 13:12
@lfdt-bot

lfdt-bot commented Aug 12, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

abies added 2 commits August 13, 2026 11:19
Signed-off-by: Artur Biesiadowski <artur.biesiadowski@swirldslabs.com>
Signed-off-by: Artur Biesiadowski <artur.biesiadowski@swirldslabs.com>
@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #26805      +/-   ##
============================================
+ Coverage     70.45%   70.47%   +0.01%     
+ Complexity    11674    11672       -2     
============================================
  Files          2582     2582              
  Lines        108331   108316      -15     
  Branches      12117    12114       -3     
============================================
+ Hits          76330    76332       +2     
+ Misses        28017    27998      -19     
- Partials       3984     3986       +2     
Files with missing lines Coverage Δ Complexity Δ
...in/java/org/hiero/consensus/model/node/NodeId.java 68.00% <ø> (+3.89%) 0.00 <0.00> (ø)
...ensus/constructable/ConstructableRegistration.java 87.50% <ø> (-0.74%) 0.00 <0.00> (ø)

... and 10 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@testlens-app

testlens-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: fd0ee6e
▶️ Tests: 125 executed
⚪️ Checks: 50/50 completed


Learn more about TestLens at testlens.app.

@abies
abies requested a review from netopyr August 14, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove SelfSerializable from NodeId

2 participants