Skip to content

chore: replace BouncyCastle BigIntegers and Arrays with JDK equivalents - #26793

Merged
anthony-swirldslabs merged 2 commits into
mainfrom
26792-bcArraysBigIntegers
Aug 13, 2026
Merged

chore: replace BouncyCastle BigIntegers and Arrays with JDK equivalents#26793
anthony-swirldslabs merged 2 commits into
mainfrom
26792-bcArraysBigIntegers

Conversation

@anthony-swirldslabs

Copy link
Copy Markdown
Contributor

Description:
CN code uses

  • org.bouncycastle.util.Arrays
  • org.bouncycastle.util.BigIntegers

We want to replace these with standard JDK APIs to reduce 3rd-party dependencies.

Related issue(s):

Fixes #26792

Notes for reviewer:
All tests should pass.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
@anthony-swirldslabs anthony-swirldslabs added this to the v0.79 milestone Aug 11, 2026
@anthony-swirldslabs anthony-swirldslabs self-assigned this Aug 11, 2026
@anthony-swirldslabs
anthony-swirldslabs requested a review from a team as a code owner August 11, 2026 22:58
@lfdt-bot

lfdt-bot commented Aug 11, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...hedera/node/app/hapi/utils/ethereum/EthTxData.java 87.50% 0 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #26793   +/-   ##
=========================================
  Coverage     70.47%   70.47%           
- Complexity    11673    11675    +2     
=========================================
  Files          2583     2583           
  Lines        108373   108379    +6     
  Branches      12123    12124    +1     
=========================================
+ Hits          76375    76381    +6     
  Misses        28013    28013           
  Partials       3985     3985           
Files with missing lines Coverage Δ Complexity Δ
...hedera/node/app/hapi/utils/ethereum/EthTxData.java 86.79% <87.50%> (-0.08%) 93.00 <2.00> (+2.00) ⬇️

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

timfn-hg
timfn-hg previously approved these changes Aug 12, 2026
Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
@swirlds-automation
swirlds-automation dismissed timfn-hg’s stale review August 12, 2026 20:49

1 file(s) changed in commit eaadf51

@testlens-app

testlens-app Bot commented Aug 12, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: eaadf51
▶️ Tests: 23260 executed
⚪️ Checks: 48/48 completed


Learn more about TestLens at testlens.app.

@anthony-swirldslabs
anthony-swirldslabs merged commit 1cf179f into main Aug 13, 2026
57 checks passed
@anthony-swirldslabs
anthony-swirldslabs deleted the 26792-bcArraysBigIntegers branch August 13, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace BouncyCastle BigIntegers and Arrays with JDK equivalents

3 participants