support mattermost attachment format - #200
Open
limwz01 wants to merge 1 commit into
Open
Conversation
Owner
|
TIL Mattermost. @limwz01 does this PR break existing image links? Just want to make sure everything else that works before still does and that there will be no regression from merging this. Thanks |
Contributor
Author
|
hmm, I'm really not sure, because I don't have access to get an official slack export and so far I've only been using slackdump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support the attachments in the mattermost output type, it was necessary to rewrite the image links to reference the corresponding path in the ZIP file: