Added support to not send responses when the handler has already called finish() - #100
Closed
vivekfantain wants to merge 1 commit into
Closed
Added support to not send responses when the handler has already called finish()#100vivekfantain wants to merge 1 commit into
vivekfantain wants to merge 1 commit into
Conversation
…y called finished(). This is useful for HTTP 304 implementation
Owner
|
Thanks for the patch. Can you fix the unit tests that are failing as well? You just need to update the mock mixin. |
Owner
|
Superseded by #108, closing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this problem when I wanted to implement HTTP 304 for some of my JSON get APIs. I did a self.set_header(304) and self.finish() that broke tornado which complained that we are writing a response after finish(). So I have modified JSendMixin to not send a response if the finish is already called. Unfortunately this relies on Tornado's internal '_finish' flag which is not exposed outside.