Repository navigation
chore(@binstruct/png): run the pngsuite test again - #301
Merged
Merged
Conversation
The package deno.json excluded ./pngsuite from every Deno command, so deno test never discovered the suite and it rotted: the zlib header fields were renamed (compressionLevel -> flevel, checksum -> fcheck, isDictionaryPresent -> fdict) and the test no longer type-checked, and the tRNS and bKGD cases were added without snapshots. Drop the exclude, fix the field name, regenerate the snapshots. The snapshot values are unchanged apart from the renamed header fields. Also turn assertExists(index >= 0) into assert(index >= 0); a boolean always exists, so those steps could never fail.
Contributor
|
Docs preview: https://hertzg.github.io/jsr-monorepo/pr/301/ |
Contributor
Benchmark ResultsNo significant changes detected. 31 benchmark(s) within their noise floor. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
=======================================
Coverage 96.79% 96.79%
=======================================
Files 159 159
Lines 8499 8499
Branches 1300 1300
=======================================
Hits 8227 8227
Misses 152 152
Partials 120 120 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #300. The package
deno.jsonexcluded./pngsuitefrom every Deno command (added in #170), sodeno testnever discovered the suite and it rotted:compressionLevel->flevel,checksum->fcheck,isDictionaryPresent->fdict) and the test no longer type-checkedChanges:
excludefrompackages/@binstruct/png/deno.json(thepublish.excludeentry stays, fixtures are not published)compressiontest and a misplaced paren in oneassertExistscallassertExists(index >= 0)becomesassert(index >= 0); a boolean always exists, so those steps could never fail__snapshots__/pngsuite.test.ts.snapwithdeno test -uThe snapshot diff is the three renamed header fields and their order, plus 5 new entries. Every other value is byte-identical to the old file.
Root
deno task lintanddeno task testpass. The parallel run now reports 968 tests, up from 964, with the suite included.