Skip to content

trust: add block header remove - #958

Merged
AL-CT merged 9 commits into
mainfrom
toni/headers_remove
Apr 15, 2026
Merged

trust: add block header remove#958
AL-CT merged 9 commits into
mainfrom
toni/headers_remove

Conversation

@AL-CT

@AL-CT AL-CT commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Summary
Creates the DB code to address #920. Mimics the code in TBC.

Changes

  • Adds block_headers_remove to TrustDB.
  • Adds more explicit Error types to block_headers_insert.

@AL-CT
AL-CT requested a review from a team as a code owner April 9, 2026 15:37
@github-actions github-actions Bot added the changelog: required This pull request must update the CHANGELOG.md file or explicitly be marked with changelog: skip label Apr 9, 2026
@AL-CT AL-CT added size: L This change is large (+/- <500) changelog: skip This pull request does not require a changelog entry (e.g. tests, docs, CI, minor refactors). area: trust This is a change to Trust (Tiny Bitcoin Rust) and removed changelog: required This pull request must update the CHANGELOG.md file or explicitly be marked with changelog: skip labels Apr 9, 2026
@codecov

codecov Bot commented Apr 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

ClaytonNorthey92
ClaytonNorthey92 requested changes Apr 9, 2026
View reviewed changes
Comment thread crates/trust/src/trust_db.rs Outdated
Comment thread crates/trust/src/trust_db.rs Outdated
Comment thread crates/trust/src/trust_db.rs
Comment thread crates/trust/src/trust_db.rs
Comment thread crates/trust/src/trust_db.rs
Comment thread crates/trust/src/trust_db.rs
@ClaytonNorthey92

ClaytonNorthey92 commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

don't merged quite yet, talked with @AL-CT on slack to add one more change

@AL-CT
AL-CT force-pushed the toni/headers_remove branch from 0a100e5 to 636fce9 Compare April 13, 2026 10:28
@AL-CT

AL-CT commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Seems that rand (one of the deps for primitive-types) had an issue reported this weekend, which has since been patched. I don't think we can directly override this, so might have to wait for primitive_types to update (there is a dependabot PR to fix this), or use some other U256 implementation.

@socket-security

socket-security Bot commented Apr 13, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Addedcargo/​ethnum@​1.5.210010095100100

View full report

@AL-CT

AL-CT commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

Replaced the primitive-types with ethnum. It fullfills the same purpose and is much more self-contained.

@AL-CT
AL-CT merged commit 759e2b9 into main Apr 15, 2026
16 of 17 checks passed
@AL-CT
AL-CT deleted the toni/headers_remove branch April 15, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ClaytonNorthey92 ClaytonNorthey92 ClaytonNorthey92 approved these changes
@joshuasing joshuasing joshuasing approved these changes
@jcvernaleo jcvernaleo Awaiting requested review from jcvernaleo

Assignees

No one assigned

Labels

area: trust This is a change to Trust (Tiny Bitcoin Rust) changelog: skip This pull request does not require a changelog entry (e.g. tests, docs, CI, minor refactors). size: L This change is large (+/- <500)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AL-CT @ClaytonNorthey92 @joshuasing