Skip to content

fix eigh to accept complex-valued DNDarrays #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GioPede wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix eigh to accept complex-valued DNDarrays #2328

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6832ffe
fix eigh to accept complex-valued DNDarrays
GioPede May 27, 2026
e64696e
Merge branch 'main' into fix/eigh-complex
brownbaerchen May 29, 2026
0191089
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions heat/core/linalg/eigh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from ..manipulations import vstack, hstack, concatenate, diag, balance
from .. import statistics
from mpi4py import MPI
from ..sanitation import sanitize_in_nd_realfloating
from ..sanitation import sanitize_in


__all__ = ["eigh"]
Expand Down Expand Up @@ -50,15 +50,15 @@ def _subspaceiteration(
matrix sign function in two iterations: The power of Zolotarev's functions. SIAM Review, 58(3).
"""
# set parameters for convergence
if A.dtype == types.float64:
if A.dtype == types.float64 or A.dtype == types.complex128:
maxit = 3 if maxit is None else maxit
tol = 1e-8 if tol is None else tol
elif A.dtype == types.float32:
elif A.dtype == types.float32 or A.dtype == types.complex64:
maxit = 6 if maxit is None else maxit
tol = 1e-4 if tol is None else tol
else:
raise TypeError(
f"Input DNDarray must be of data type float32 or float64, but is of type {A.dtype}."
f"Input DNDarray must be of data type float32, float64, complex64, or complex128, but is of type {A.dtype}."
)

Anorm = matrix_norm(A, ord="fro")
Expand Down Expand Up @@ -300,7 +300,9 @@ def eigh(
--------
:func:`heat.linalg.polar`
"""
sanitize_in_nd_realfloating(A, "A", [2])
sanitize_in(A)
if A.ndim != 2:
raise ValueError(f"Input matrix must be two-dimensional, but input shape was {A.shape}.")
if A.shape[0] != A.shape[1]:
raise ValueError(
f"Input matrix must be symmetric and, consequently, square, but input shape was {A.shape[0]} x {A.shape[1]}."
Expand Down
Loading