Implementation of local outlier factor - #1825
Open
Hakdag97 wants to merge 282 commits into
Open
Conversation
for more information, see https://pre-commit.ci
mrfh92
reviewed
Dec 19, 2025
Collaborator
There was a problem hiding this comment.
- lines 267-282 in _chunk_wise_topk (i.e. the whole "else-block" for chunks!=1) seem not to get tested.
- lines 266-277 in _map_idx_to_proc are not covered.
If these parts of the code are somehow core ideas of the changes (are they?), they should be covered to ensure that they work.
…Implementation_of_local_outlier_factor
…processes in cdist_small
Contributor
|
Thank you for the PR! |
Contributor
|
Thank you for the PR! |
Contributor
|
Thank you for the PR! |
Contributor
|
Thank you for the PR! |
Contributor
|
Thank you for the PR! |
Contributor
|
This pull request is stale because it has been open for 60 days with no activity. |
Member
|
@Hakdag97 do you want to try to update this branch? Also testing it with the updated indexing branch wouldn't be bad. Just let us know if you have no time and we'll manage somehow. Next release is planned in September. |
Contributor
|
This pull request is stale because it has been open for 60 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added an implementation of the local outlier factor (lof) used for outlier classification. The bottleneck to reduce memory consumption lies in the pairwise distance matrix. Memory consumption can be significantly reduced by taking only the n smallest elements in the distance matrix into account (only these are needed to compute the lof). Thus, a new distance matrix, called cdist_small, was established that combines the functionality of cdist and topk, but has the advantage that the smallest n distances are dynamically choosen during computation without evaluating the whole distance matrix cdist at once.
Issue/s resolved: #1758
Changes proposed:
Type of change
Does this change modify the behaviour of other functions? If so, which?
no