Document how to prevent YAML-injection in Chart Templates? [2]#2165
Draft
meeque wants to merge 14 commits into
Draft
Document how to prevent YAML-injection in Chart Templates? [2]#2165meeque wants to merge 14 commits into
meeque wants to merge 14 commits into
Conversation
Author
|
Note: I've tried to stick to the existing writing style of the appendix. I know that it contradicts the style-guide, but imho that should be addressed through a separate issue... |
Adjust document structure so that contents about secure YAML templating can be added more easily in the future. Signed-off-by: Michael Riedel <meeque@meeque.de>
Move the existing section about indenting and templates after the new section, because it also generates strings from dynamic values. Also add some TODO markers for other sections. Signed-off-by: Michael Riedel <meeque@meeque.de>
Signed-off-by: Michael Riedel <meeque@meeque.de>
Signed-off-by: Michael Riedel <meeque@meeque.de>
Also improve text and formatting in a few related sections. And add more specific TODOs. Signed-off-by: Michael Riedel <meeque@meeque.de>
Signed-off-by: Michael Riedel <meeque@meeque.de>
Signed-off-by: Michael Riedel <meeque@meeque.de>
Signed-off-by: Michael Riedel <meeque@meeque.de>
Signed-off-by: Michael Riedel <meeque@meeque.de>
Signed-off-by: Michael Riedel <meeque@meeque.de>
Signed-off-by: Michael Riedel <meeque@meeque.de>
Signed-off-by: Paige Calvert <eura.calvert@gmail.com> Signed-off-by: Michael Riedel <meeque@meeque.de>
Signed-off-by: Paige Calvert <eura.calvert@gmail.com> Signed-off-by: Michael Riedel <meeque@meeque.de>
Signed-off-by: Paige Calvert <eura.calvert@gmail.com> Signed-off-by: Michael Riedel <meeque@meeque.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative PR for #2154.
I had the impression that previous PR #2158 didn't fit well with existing contents of the "YAML Techniques" appendix.
This PR attempts to address this by editing that appendix more heavily. Major changes are:
(Not sure about this decision, can revert if original order is deemed preferable.)
I know this is a big edit, sorry for the spam. But I feel it conveys what template authors need to know about generating YAML.