Document uninstall hook apply method follows release latching behavior#2142
Open
promptless-for-oss wants to merge 1 commit into
Open
Document uninstall hook apply method follows release latching behavior#2142promptless-for-oss wants to merge 1 commit into
promptless-for-oss wants to merge 1 commit into
Conversation
helm/helm PR #32232 adds a --server-side flag to helm uninstall so pre-delete and post-delete hooks follow the release's previous apply method by default instead of hardcoding server-side apply. Extend the Server-Side Apply overview section to cover uninstall. Signed-off-by: promptless[bot] <promptless[bot]@users.noreply.github.com>
| The behavior can be overridden by setting the `--server-side` flag explicitly. | ||
| When you upgrade, roll back, or uninstall a release, Helm follows the release's previous apply method by default. | ||
| This latching behavior ensures continuity of operation for existing releases that used client-side apply. | ||
| For `helm uninstall`, the previous apply method governs the pre-delete and post-delete hooks. |
Contributor
Author
There was a problem hiding this comment.
helm/helm PR #32232 adds a --server-side flag (auto/true/false, default auto) to helm uninstall. Per pkg/action/uninstall.go, pre-delete and post-delete hooks previously hardcoded server-side apply to true; the change wires them through getServerSideApplyValue() so auto follows the release's stored apply method — matching upgrade and rollback. This extends the overview's latching-behavior description to cover uninstall.
Source: helm/helm#32232
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open this suggestion in Promptless to view citations and reasoning process
Updates the Server-Side Apply section in the Helm 4 overview to note that uninstall (pre-delete and post-delete hooks) follows the release's previous apply method by default, and can be overridden with the
--server-sideflag — matching upgrade and rollback. Reflects helm/helm PR #32232.Trigger Events
Tip: Worried about broken links? Ask Promptless to find and fix them automatically 🔗