[Issue 323] add support for disk replication flag

[domrim]

Description

Added support for configuring the "replication" parameter of disks.

Resolved Issues

Closes #329
Closes #323

Rollback Plan

If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

NA

[hashicorp-cla-app]

All committers have signed the CLA.

[PendaGTP]

Ping

Any timeline for review/merge? I'm also interested in this feature

[PendaGTP]

@nywilken @lbajolet-hashicorp

Sorry for pinging directly, idk which people are maintaining this repo.

[ksl28]

I am now facing the same issue, and was surprised to see, that the only thing missing - is the code review.
@tanmay-hc - sorry for tagging, but could you be of assistance here?

[tanmay-hc]

1. The go test TestGenerateProxmoxDisks fails because the existing expected fixtures were not updated for the new Replicate field in the "bunch of disks" cases.
2. Please add/adjust coverage for the default path as well as skip_replication=true. Right now the change proves the opt-out case, but it should also assert that existing builds keep the same effective behavior when skip_replication is unset.
3. Behavior looks additive, but this touches disk creation for every bus type. Please update the existing fixture expectations in the two multi-disk cases so the suite passes before merge.

[domrim]

1. The go test TestGenerateProxmoxDisks fails because the existing expected fixtures were not updated for the new Replicate field in the "bunch of disks" cases.

   2. Please add/adjust coverage for the default path as well as skip_replication=true. Right now the change proves the opt-out case, but it should also assert that existing builds keep the same effective behavior when skip_replication is unset.

   3. Behavior looks additive, but this touches disk creation for every bus type. Please update the existing fixture expectations in the two multi-disk cases so the suite passes before merge.

thx for the review. i adjusted the tests according to your requests. please have a look if this is now sufficient, if anything is still missing i can implement them.

[tanmay-hc]

@domrim The changes look good to me now. Can you just run a make generate?

[domrim]

@domrim The changes look good to me now. Can you just run a make generate?

documentation should be up2date now