hclwrite: parse object-construct expressions#810
Open
bbasata wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds an AST for object-construct expressions such as:
Given an
hclwrite.Expression, an application can read an object value as:Retrieval is based on matching a Go string to an HCL identifier. As an implementation choice, there is no way to retrieve the value for the variable expression
(cat)at the time of this pull request.#811 is a speculative pull request that builds on this one and introduces the capability to rewrite objects.
Related Issue
#695 and design notes from Martin in #695 (comment).
How Has This Been Tested?
hclwrite/parser_test.go