fix: prevent network node restart loops - #227
Merged
Merged
Conversation
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
JeffreyDallas
force-pushed
the
agent/prevent-network-node-restart-loop
branch
from
July 31, 2026 19:05
4de1235 to
a9f85c0
Compare
JeffreyDallas
marked this pull request as ready for review
July 31, 2026 19:05
jeromy-cannon
approved these changes
Aug 10, 2026
|
🎉 This PR is included in version 0.46.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The finish handler set s6's
onceflag only after a zero exit code. Fatal CN startup failures exit nonzero, so s6 immediately retried them in a loop.Validation
bash -n docker/debian-s6-java25/rootfs/etc/s6-overlay/s6-rc.d/network-node/finishgit diff --check1runs once rather than restartingrelates to hiero-ledger/solo#4388