Skip to content

chore: get workflows up to standards - #307

Open
PavelSBorisov wants to merge 6 commits into
mainfrom
fix-workflow-standards
Open

chore: get workflows up to standards#307
PavelSBorisov wants to merge 6 commits into
mainfrom
fix-workflow-standards

Conversation

@PavelSBorisov

@PavelSBorisov PavelSBorisov commented May 15, 2026

Copy link
Copy Markdown
Contributor

Description:

Related issue(s):

Fixes #306

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@swirlds-automation

swirlds-automation commented May 15, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Comment thread .github/workflows/zxc-setup-solo-stack.yml Fixed
@codecov-commenter

codecov-commenter commented May 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.20%. Comparing base (3c494cd) to head (33d0c07).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   89.20%   89.20%           
=======================================
  Files          23       23           
  Lines        2372     2372           
  Branches      222      222           
=======================================
  Hits         2116     2116           
  Misses        198      198           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: PavelSBorisov <pavel.s.borisov@gmail.com>
@PavelSBorisov
PavelSBorisov force-pushed the fix-workflow-standards branch from aa0cdaa to bb94986 Compare May 15, 2026 15:01
Signed-off-by: PavelSBorisov <pavel.s.borisov@gmail.com>
Signed-off-by: PavelSBorisov <pavel.s.borisov@gmail.com>
Signed-off-by: PavelSBorisov <pavel.s.borisov@gmail.com>
@PavelSBorisov
PavelSBorisov marked this pull request as ready for review May 15, 2026 15:39
@PavelSBorisov
PavelSBorisov requested review from a team as code owners May 15, 2026 15:39
@PavelSBorisov
PavelSBorisov requested a review from rbarker-dev May 15, 2026 15:39
Signed-off-by: PavelSBorisov <pavel.s.borisov@gmail.com>
BartoszSolkaBD
BartoszSolkaBD previously approved these changes May 15, 2026
Comment thread .github/workflows/support/scripts/setup-solo-stack.sh

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should update to node 24

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 24 seems to break some things, I tried a direct bump but got consistent failures in CI - https://github.com/hashgraph/hedera-forking/actions/runs/25926032257/job/76504944946

Comment thread .github/workflows/support/scripts/setup-solo-stack.sh Outdated
Signed-off-by: PavelSBorisov <pavel.s.borisov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tech Debt]: Convert .github/actions/setup-solo-stack/action.yaml to reusable workflow

7 participants