Conversation
Signed-off-by: Albin Sun <albin.sun@suse.com>
There was a problem hiding this comment.
🟡 Changes recommended
The port omits the original successful file upload/re-upload regression scenario and excludes one migrated test from p0 runs.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Ports backend image tests to source-specific Robot Framework suites and extends image/volume keywords.
Changes:
- Splits URL, file, and volume image tests into dedicated suites.
- Adds REST-backed file upload and image/volume assertions.
- Marks migrated pytest cases and relocates storage-network tests.
File summaries
| File | Description |
|---|---|
tests/regression/storage_network/test_storage_network.robot |
Updates resource paths after relocation. |
tests/regression/image/test_image.robot |
Removes the former combined image suite. |
tests/regression/image/test_image_from_volume.robot |
Adds volume-export image coverage. |
tests/regression/image/test_image_from_url.robot |
Adds URL lifecycle and metadata tests. |
tests/regression/image/test_image_from_file.robot |
Adds invalid file-upload coverage. |
libs/keywords/image_keywords.py |
Exposes file-upload functionality. |
libs/image/rest.py |
Implements REST file upload. |
libs/image/image.py |
Routes uploads through REST. |
libs/image/crd.py |
Declares file uploads unsupported through CRD. |
libs/image/base.py |
Adds the file-upload interface. |
libs/image/__init__.py |
Defines the public image export. |
keywords/volume.resource |
Adds reusable volume creation workflow. |
keywords/image.resource |
Adds state, size, absence, and upload keywords. |
keywords/common.resource |
Updates unique-name documentation. |
integrations/test_1_images.py |
Marks backend image tests as Robot-ported. |
Review details
- Files reviewed: 15/15 changed files
- Comments generated: 4
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Albin Sun <albin.sun@suse.com>
fa1bac9 to
1cf8307
Compare
|
Tick the box to add this pull request to the merge queue (same as
|
Vicente-Cheng
left a comment
Vicente-Cheng
left a comment
There was a problem hiding this comment.
Some nits, please also update the README with these PR changes.
thanks!
|
|
||
| *** Test Cases *** | ||
| Create Image From Volume | ||
| [Tags] p0 |
There was a problem hiding this comment.
This is the generic case for the VM image. Could we also add this to the pr-baseline?
| Create Image From Volume | ||
| [Tags] p0 | ||
| [Documentation] Create an image from a 10Gi volume and verify its status and size | ||
| Given A 10Gi Volume is Created ${VOL_NAME} |
There was a problem hiding this comment.
do we really need 10Gi? If we would like to ensure the behavior, maybe 1Gi would be enough?
| *** Keywords *** | ||
| Local Suite Setup | ||
| ${suffix}= Generate Unique Name | ||
| Set Suite Variable ${VOL_NAME} vol-${SUFFIX} |
There was a problem hiding this comment.
| Set Suite Variable ${VOL_NAME} vol-${SUFFIX} | |
| Set Suite Variable ${VOL_NAME} vol-${suffix} |
There was a problem hiding this comment.
nit, it works, but it's better to align the format
Which issue(s) this PR fixes:
What this PR does / why we need it:
test_1_images.py:TestBackendImagesto robotfrom_url,from_fileorfrom_volume.pr-baselinetag to test case self, thus keep the GH action selection for PR and also fits the source grouping.Special notes for your reviewer:
test_1_images.py:TestBackendImages.TestImageWithStorageNetworkandTestImageEnhancementswill be cover in later PRs.Additional documentation or context
./run.sh -s image -p 4