Fix ModuleNotFoundError: No module named 'pkg_resources' error

[votdev]

... which is caused due pypa/setuptools#5007.

Running tests...
==============================================================================
Test Vm :: VM Test Cases: basic lifecycle, create-stopped, and volume hot-p...
==============================================================================
Test VM Basic Lifecycle :: Test basic VM creation, start, stop, de... | FAIL |
Parent suite setup failed:
ModuleNotFoundError: No module named 'pkg_resources'
------------------------------------------------------------------------------
Create Stopped VM Stays Stopped :: A VM created with runStrategy=H... | FAIL |
Parent suite setup failed:
ModuleNotFoundError: No module named 'pkg_resources'
------------------------------------------------------------------------------
Start Stopped VM :: Starting the stopped VM brings it to running      | FAIL |
Parent suite setup failed:
ModuleNotFoundError: No module named 'pkg_resources'
------------------------------------------------------------------------------
Hot-Plug Volume Into Running VM :: Hot-plug an existing volume int... | FAIL |
Parent suite setup failed:
ModuleNotFoundError: No module named 'pkg_resources'
------------------------------------------------------------------------------
Hot-Unplug Volume From Running VM :: Hot-unplug the disk; it must ... | FAIL |
Parent suite setup failed:
ModuleNotFoundError: No module named 'pkg_resources'
------------------------------------------------------------------------------
Test Vm :: VM Test Cases: basic lifecycle, create-stopped, and vol... | FAIL |
Suite setup failed:
ModuleNotFoundError: No module named 'pkg_resources'

5 tests, 0 passed, 5 failed

Additional fixes:

• Fix crash when using a nightly build cluster which returns a git hash instead a semver.

InvalidVersion: Invalid version: 'c6d323ec'

[m-ildefons]

AFAIK, the dependencies of the robot tests are managed through requirements.in/requirements.txt in the harvester_robot_tests directory, not the top-level requirements files.

Aside from that, I'd prefer to pin this with the other dependencies rather than have it as separate install command documented.

[m-ildefons]

Why not just add this to test-requirements.in?

The fact that this isn't pinned there is even warned about in test-requirements.txt:

# WARNING: The following packages were not pinned, but pip requires them to be
# pinned when the requirements file includes hashes and the requirement is not
# satisfied by a package already installed. Consider using the --allow-unsafe flag.
# setuptools

[albinsun]

Yeah, if this package is missing in a fresh robot env., we should add it in requirement.in and regenerate requirement.txt too.

[votdev]

pip-tools is considering setuptools as unsafe. But we can force it with --allow-unsafe. I think that’s fine in our case, as we specifically need this version of setuptools.

[votdev]

With my first attempt at the PR, I didn’t want to do anything that went against the ‘normal’ behaviour of pip-tools; but I think forcing it is ultimately the better and simpler solution.