Make run_lockstep surface UnknownFamily warnings like check/test#63
Merged
Conversation
run_lockstep validated stm32.toml via check(), which silently falls back to the F446RE database for an unrecognized [device].family with no indication anything was approximated. check_family() exists specifically to surface that as a warning, and run_check/run_test already use it — run_lockstep now does too, so all three commands behave consistently for an unknown family.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53
Summary
run_lockstepvalidatedstm32.tomlvianucleus_compiler::check(), which silently falls back to the F446RE database for an unrecognized[device].familywith no warning — unlikerun_checkandrun_test, which usecheck_family()and print a fallback warning to stderr.run_locksteptocheck_family()and added the same warning printingrun_checkalready does, sonucleus lockstepno longer silently validates an unknown family against the wrong DB without telling the user.Test plan
lockstep_warns_on_unknown_family_instead_of_silently_falling_back, an integration test that runsnucleus lockstepagainst a project withfamily = "STM32H750"and asserts stderr contains theunsupported device familywarning.cargo test -p nucleus-cli— 40 passedcargo clippy -p nucleus-cli --all-targets -- -D warnings— cleancargo fmt --all -- --check— cleanGenerated by Claude Code