Stop hardware write_memory from discarding a successful write on resume failure - #59
Merged
Conversation
…me failure write_memory chained halt/mww/resume behind a single \`?\`, so a resume failure after a successful write propagated as the whole function's error, discarding the fact the write itself had already landed. write_result and resume_result are now tracked separately: resume is always attempted once halt succeeds, and a resume failure is recorded without overwriting a successful write result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49
Summary
HardwareBackend::write_memorychainedhalt→mww→resumebehind a single?-propagating async block. Aresumefailure after a successfulmwwwrite propagated as the whole function's error, discarding the fact the write itself had already landed — and (mirroring issue hardware read_memory: early ? skips resume, leaving STM32 permanently halted in OpenOCD #48) anmwwfailure would skipresumeentirely, leaving the target halted.write_memorynow trackswrite_resultandresume_resultseparately:resumeis always attempted oncehalthas actually succeeded, and a resume failure is recorded viarecord_failurewithout overwriting a successful write result.Test plan
write_memory_keeps_a_successful_write_even_when_resume_fails: a mock telnet server that lets themwwwrite land, then forces the connection closed so the subsequentresumefails — asserts the function still returnsOk(())and the failure is recorded.cargo test -p nucleus-hil --lib— 64 passed.cargo clippy -p nucleus-hil -p nucleus-cli --all-targets -- -D warnings— clean.cargo fmt --all -- --check— clean.Generated by Claude Code