consensus: surface late and excluded commit signatures to operators - #5093
Open
GheisMohammadi wants to merge 1 commit into
Open
consensus: surface late and excluded commit signatures to operators#5093GheisMohammadi wants to merge 1 commit into
GheisMohammadi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validators can lose signing percentage when their commit vote arrives too late for FBFT to include it. That is expected protocol behavior, but today there is often no clear local signal—only a drop in signing stats.
This PR adds logging and a Prometheus metric so operators can see when:
Consensus behavior is unchanged. Late votes are still dropped; we only make that visible.
Metric
hmy_consensus_late_signature{role,phase}role=validator,phase=committed— local key missing from final commit bitmaprole=leader,phase=PREPARE|COMMIT— vote for the previous (just finalized) block