Skip to content

Add skip_setup_flow flag to oauth#1454

Open
lordbagel42 wants to merge 6 commits into
hackclub:mainfrom
lordbagel42:main
Open

Add skip_setup_flow flag to oauth#1454
lordbagel42 wants to merge 6 commits into
hackclub:mainfrom
lordbagel42:main

Conversation

@lordbagel42

@lordbagel42 lordbagel42 commented Jun 26, 2026

Copy link
Copy Markdown

Summary of the problem

Hackatime requires setting up a code editor before connecting to Stardance, in addition the homepage is very coding centric and discouraging. Homepage changes have been moved to #1456

Describe your changes

When skip_setup_flow is passed into the hackatime oauth it skips to step4 of the WakatimeSetup flow & showcases a banner that setting up a code editor was skipped. This way, everybody still has to agree to the rules.

This PR is blocking for hackclub/stardance#702

Screenshots / Media

Video showcasing Stardance using the new flag:
https://github.com/user-attachments/assets/d14be4ae-9b8a-4ecf-a103-22de7d8b05ab

@greptile-apps

greptile-apps Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds a shortened Wakatime setup path for OAuth flows that pass skip_setup_flow. The main changes are:

  • Preserves skip_setup_flow in return data across sign-in redirects.
  • Sends skipped setup users directly to the final Wakatime setup step.
  • Adds a skipped setup banner and Fair Play acknowledgment UI before continuing.
  • Keeps the OAuth return URL available for the final continue button.

Confidence Score: 5/5

The changes are narrowly scoped to preserving an OAuth flag and adjusting the setup flow UI around that flag.

No code issues were identified in the reviewed changes, and the implementation appears consistent with the described setup-skip behavior.

T-Rex T-Rex Logs

What T-Rex did

  • Executed the OAuth skip flow repro script to validate the integration scenario; observed base and head checkout tests exit with code 127 due to missing Ruby.
  • Explored the Waketime skip UI flow by reviewing end-to-end renders; the after-state shows a skipped-editor banner and Fair Play Policy gate, and the final action becomes enabled after agreeing.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (7): Last reviewed commit: "remove whitespace + remove debug log + c..." | Re-trigger Greptile

Comment thread app/controllers/sessions_controller.rb Outdated
Comment thread app/javascript/pages/WakatimeSetup/Index.svelte
Comment thread app/controllers/static_pages_controller.rb Outdated
Comment thread app/javascript/pages/WakatimeSetup/Index.svelte Outdated
Comment thread app/services/hca_service.rb Outdated
Comment thread app/javascript/pages/WakatimeSetup/Index.svelte Outdated
Comment thread app/controllers/sessions_controller.rb Outdated
Comment thread app/javascript/pages/WakatimeSetup/Index.svelte Outdated
@skyfallwastaken

skyfallwastaken commented Jun 28, 2026

Copy link
Copy Markdown
Member

@greptileai one final check por favor?

(bagel - lgtm but I'd like to double check :pf:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants