Skip to content

urllib: set Content-Length header in the response #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xrmx wants to merge 2 commits into
base: master
Choose a base branch
from
Open

urllib: set Content-Length header in the response #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
081ac5f
urllib: set Content-Length header in the response
xrmx Apr 16, 2026
ba3c504
Fix formatting
xrmx Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/pook/interceptors/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import io
import socket
from http.client import _CS_REQ_SENT, HTTPMessage # type: ignore[attr-defined]
from http.client import _CS_REQ_SENT, parse_headers # type: ignore[attr-defined]
from http.client import HTTPSConnection

from http.client import (
Expand Down Expand Up @@ -75,8 +76,12 @@ def _on_request(self, _request, conn, method, url, body=None, headers=None, **kw
# urllib requires `code` to be set, rather than `status`
mockres.code = res._status
mockres.reason = http_reasons.get(res._status)
mockres.headers = HTTPMessage()
mockres.length = len(res._body or b"")
content_length = len(res._body or b"")
headers_fp = io.BytesIO(
f"Content-Length: {content_length}\r\n".encode("iso-8859-1")
)
mockres.headers = parse_headers(headers_fp)
mockres.length = content_length

for hkey, hval in res._headers.itermerged():
mockres.headers.add_header(hkey, hval)
Expand Down
8 changes: 6 additions & 2 deletions tests/unit/interceptors/urllib_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,9 @@ def test_urllib_ssl():
res = urlopen("https://example.com")

assert res.read() == b"Hello from pook"
assert res.length == 15
assert res.version == 11
assert res.length == 15
assert res.headers.get("Content-Length") == "15"


@pytest.mark.pook
Expand All @@ -47,7 +48,9 @@ def test_urllib_clear():
res = urlopen("http://example.com")

assert res.read() == b"Hello from pook"
assert res.version == 11
assert res.length == 15
assert res.headers.get("Content-Length") == "15"


@pytest.mark.pook
Expand All @@ -56,5 +59,6 @@ def test_without_body_response_length_is_zero():
res = urlopen("http://example.com")

assert res.read() == b""
assert res.length == 0
assert res.version == 11
assert res.length == 0
assert res.headers.get("Content-Length") == "0"
Loading