Split regenerate and fork into separate buttons with working "don't how again" - #161
Open
rickintoplace wants to merge 1 commit into
Open
Split regenerate and fork into separate buttons with working "don't how again"#161rickintoplace wants to merge 1 commit into
rickintoplace wants to merge 1 commit into
Conversation
…how again' The regenerate confirmation offered two different operations in one dialog, so a persistent 'don't show this again' would have locked the user into one of them. On top of that the checkbox never took effect: it wrote to localState.dontShow, which regenerate() then overwrote with its own stale copy of localState, and which is not persisted anywhere. Regenerate and fork are now separate buttons on the user message, each with its own dialog explaining that single operation. The opt-out is stored per warning in interface_settings (redux-persist), so it survives reloads and other conversations. The dialog itself is now a generic ConfirmActionModal, opened through confirmAction() from the modal context, which skips it when the user turned it off. The fork button on assistant messages uses the same dialog and icon, and its toasts are no longer hardcoded German strings. Fixes gwdg#160
rickintoplace
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160
The regenerate confirmation offered two different operations in one dialog, so a persistent "don't show this again" would have locked the user into one of them. On top of that the checkbox never took effect: it wrote to localState.dontShow, which regenerate() then overwrote with its own stale copy of localState, and which is not persisted anywhere.
Regenerate and fork are now separate buttons on the user message, each with its own dialog explaining that single operation. The opt-out is stored per warning in interface_settings (redux-persist), so it survives reloads and other conversations.
The dialog itself is now a generic ConfirmActionModal, opened through confirmAction() from the modal context, which skips it when the user turned it off. The fork button on assistant messages uses the same dialog and icon.