Remove old banksim/faithsim workflows add documentation/tests for new ones - #5392
Open
spxiwh wants to merge 10 commits into
Open
Remove old banksim/faithsim workflows add documentation/tests for new ones#5392spxiwh wants to merge 10 commits into
spxiwh wants to merge 10 commits into
Conversation
Contributor
Author
|
The CI test is taking too long. I'll need to reduce the work being done there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's time for
pycbc_make_banksimandpycbc_make_faithsimto be retired. They've been greatly useful over the years (evolving from earlier codes pre-PyCBC) but they're now redundant with modern PyCBC-pegasus workflow based generators.This patch:
glue)Standard information about the request
This is a: Removal of old code
This change affects: the banksim/faithsim suite
This change changes: scientific output
This change: has appropriate unit tests, follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
This change will: break current functionality
Motivation
It's time to get rid of our old workflows (which basically don't work now) and make the new ones front-and-centre on our documentation. We also need to ensure that users can easily use the new codes, so these documentation pages needed updating.
Contents
Links to any issues or associated PRs
Fixes #4931
Testing performed
Have tested all the examples on CIT and locally using Claude to convert a dax to things we can run on my mac which doesn't have condor.
Additional notes
Thanks Claude!