Skip to content

Automated code quality improvements #5384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spxiwh wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Automated code quality improvements #5384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b92dc6
Running automated ruff format fix on all codes
spxiwh Jul 27, 2026
cde2d86
Check the bin files too
spxiwh Jul 27, 2026
18460a6
Still need monkeypatch here, add NOQA to it
spxiwh Jul 29, 2026
ba2f9ad
Avoid circular import
spxiwh Jul 29, 2026
5c32566
Fix pre-existing typo that wasn't noticed before
spxiwh Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
30 changes: 30 additions & 0 deletions .qlty/qlty.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,25 @@ exclude_patterns = [
"test/**",
]

# bin/ holds ~220 Python executables with no .py extension (just a
# `#!/usr/bin/env python` shebang). Qlty's default Python file-type
# detection doesn't pick these up (unlike ruff itself, which sniffs
# shebangs fine when run directly), so they were silently skipped by
# every qlty_check run. Extending the glob list to include bin/** fixes
# that; the rest of the list matches Qlty's own documented default.
[file_types.python]
globs = [
"*.py",
"*.pyw",
"**/DEPS",
"**/Snakefile",
"**/SConscript",
"**/wscript",
"**/SConstruct",
"**/.gclient",
"bin/**",
]

[[source]]
name = "default"
default = true
Expand Down Expand Up @@ -56,3 +75,14 @@ name = "ripgrep"

[plugins.definitions.ripgrep.drivers.lint-fixme]
script = "rg \"FIXME|XXX\" ${target} --json --word-regexp --only-matching"

# bin/** (above) is a path-only glob, so it also swept in a handful of
# extensionless files under bin/ that are actually bash, not Python --
# ruff fails to parse these as Python. Skip ruff specifically for them.
[[exclude]]
plugins = ["ruff"]
file_patterns = [
"bin/pycbc_copy_output_map",
"bin/pycbc_stageout_failed_workflow",
"bin/inference/run_pycbc_inference",
]
Loading
Loading