fix: 2 improvements across 2 files - #5383
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Quality: Potential KeyError in FFT backend getter functions - Quality: Missing resource cleanup for HDF5 file handle Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Quality: Potential KeyError in FFT backend getter functions - Quality: Missing resource cleanup for HDF5 file handle Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: 2 improvements across 2 files
Problem
Severity:
High| File:pycbc/fft/backend_mkl.py:L28The
get_backend()functions inbackend_mkl.py,backend_cupy.py,backend_cpu.py, andbackend_cuda.pydirectly index into_adictusing the global backend variable (e.g.,_adict[mkl_backend]). Ifset_backend()fails to find a valid backend from the provided list, the global variable remainsNone, which will cause aKeyErrorwhenget_backend()is subsequently called.Solution
Add a check in
get_backend()to raise a more descriptive error if the backend isNone(e.g.,if mkl_backend is None: raise RuntimeError('No MKL backend available')).Changes
pycbc/fft/backend_mkl.py(modified)pycbc/frame/store.py(modified)