Adding Newtonian chirp time and time-frequency track for for TaylorF2Ecc - #5367
Open
khunsang wants to merge 14 commits into
Open
Adding Newtonian chirp time and time-frequency track for for TaylorF2Ecc #5367khunsang wants to merge 14 commits into
khunsang wants to merge 14 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds leading-order eccentric chirp-time support for
TaylorF2Eccand feature to compute time-frequency track for TaylorF2Ecc.The main changes are:
eccentric_newtonian_timeinpycbc.pnutils, based on Eq. (119) of Morras et al. arXiv:2502.03929.eccentric_chirp_timeandeccentric_spa_length_in_timeinspa_tmplt.py.TaylorF2Eccinwaveform.pyfor waveform duration/filter length handling.get_inspiral_tfto accept aneccentricityargument and supportTaylorF2Ecc.These functionalities are added for searches with
TaylorF2Ecc. This changes will not affect existing offline search, live search, inference and PyGRB.