Skip to content

Adding TaylorF2Ecc - #5339

Open
aleynaakyuz wants to merge 1 commit into
gwastro:masterfrom
aleynaakyuz:taylor
Open

Adding TaylorF2Ecc#5339
aleynaakyuz wants to merge 1 commit into
gwastro:masterfrom
aleynaakyuz:taylor

Conversation

@aleynaakyuz

Copy link
Copy Markdown
Contributor

This PR solves the error

Traceback (most recent call last):
          File "/home/aakyuz/miniconda3/envs/inj_test/bin/pycbc_inspiral", line 235, in <module>
            gwstrain = strain.from_cli(opt, dyn_range_fac=DYN_RANGE_FAC,
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
          File "/home/aakyuz/miniconda3/envs/inj_test/lib/python3.12/site-packages/pycbc/strain/strain.py", line 345, in from_cli
            injector.apply(strain, opt.channel_name.split(':')[0],
          File "/home/aakyuz/miniconda3/envs/inj_test/lib/python3.12/site-packages/pycbc/inject/inject.py", line 632, in apply
            signal = self.make_strain_from_inj_object(
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
          File "/home/aakyuz/miniconda3/envs/inj_test/lib/python3.12/site-packages/pycbc/inject/inject.py", line 710, in make_strain_from_inj_object
            hp, hc = get_td_waveform(inj, delta_t=delta_t, f_lower=f_l,
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
          File "/home/aakyuz/miniconda3/envs/inj_test/lib/python3.12/site-packages/pycbc/waveform/waveform.py", line 601, in get_td_waveform
            raise ValueError("Approximant %s not available" %
        ValueError: Approximant TaylorF2Ecc not available

@ahnitz

ahnitz commented May 31, 2026

Copy link
Copy Markdown
Member

@aleynaakyuz Please rebase from master and mamke sure the tests pass so this can be merged.

@ahnitz
ahnitz enabled auto-merge (squash) May 31, 2026 19:28
@ahnitz

ahnitz commented Jun 18, 2026

Copy link
Copy Markdown
Member

@aleynaakyuz Please rebase your PR from master, the tests should now all pass if your PR isn't breaking anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants