Skip to content

Fixed rounding bug in pycbc_dtphase #5318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SamInsley wants to merge 3 commits into
base: master
Choose a base branch
from
+10 −10
Open

Fixed rounding bug in pycbc_dtphase #5318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab7e08e
Fixed rounding bug
SamInsley Apr 8, 2026
280d570
Applied rounding fix to the application to ensure symmetry with PTA h…
SamInsley Apr 9, 2026
f8cbc0a
Applied bug fix to test live coinc
SamInsley Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bin/all_sky_search/pycbc_dtphase
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,9 @@ for ifo0 in args.ifos:
dt = (data[ifo0]['t'] - data[ifo1]['t'])
dp = (data[ifo0]['p'] - data[ifo1]['p']) % (2. * np.pi)
sr = (data[ifo1]['s'] / data[ifo0]['s'])
dtbin = (dt / twidth).astype(int)
dpbin = (dp / pwidth).astype(int)
srbin = (sr / swidth).astype(int)
dtbin = np.rint(dt / twidth).astype(int)
dpbin = np.rint(dp / pwidth).astype(int)
srbin = np.rint(sr / swidth).astype(int)

# We'll only store a limited range of ratios
if keep is None:
Expand Down
8 changes: 4 additions & 4 deletions pycbc/events/eventmgr_cython.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import numpy as np
cimport numpy as cnp
import cython
from cython import wraparound, boundscheck, cdivision
from libc.math cimport M_PI, sqrt
from libc.math cimport M_PI, sqrt, rint
from libc.math cimport round as cround


Expand Down Expand Up @@ -75,9 +75,9 @@ def logsignalrateinternals_computepsignalbins(
sdif[idx] = (s[ridx] * sense * sqrt(sigref[ridx])) / (sref[ridx] * senseref * sqrt(sig[ridx]))

for idx in range(length):
tbin[idx] = <int>(tdif[idx] / twidth)
pbin[idx] = <int>(pdif[idx] / pwidth)
sbin[idx] = <int>(sdif[idx] / swidth)
tbin[idx] = <int>rint(tdif[idx] / twidth)
pbin[idx] = <int>rint(pdif[idx] / pwidth)
sbin[idx] = <int>rint(sdif[idx] / swidth)


@boundscheck(False)
Expand Down
6 changes: 3 additions & 3 deletions test/validation_code/old_stat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,9 +543,9 @@ def logsignalrate(self, stats, shift, to_shift):
sdif = s / sref * sense / senseref * sigref / sig

# Put into bins
tbin = (tdif / self.twidth).astype(int)
pbin = (pdif / self.pwidth).astype(int)
sbin = (sdif / self.swidth).astype(int)
tbin = numpy.rint(tdif / self.twidth).astype(int)
pbin = numpy.rint(pdif / self.pwidth).astype(int)
sbin = numpy.rint(sdif / self.swidth).astype(int)
binned += [tbin, pbin, sbin]

# Convert binned to same dtype as stored in hist
Expand Down
Loading