Updating population redshift models - #5301
Open
sum33it wants to merge 8 commits into
Open
Conversation
sum33it
force-pushed
the
population_models_development
branch
from
May 4, 2026 14:08
db21f03 to
82d112d
Compare
Member
|
Summary of Updates for PyCBC Population Models
|
sum33it
force-pushed
the
population_models_development
branch
from
June 4, 2026 19:38
27f2eb8 to
696b2d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is restructuring the population redshift models using a class. It is also restructured keeping in mind a future update for population inference code. There are some improvements for existing code such as getting rid of hard coded cosmology functions like here.
Standard information about the request
This is a: new feature, and efficiency update,
This change affects: It should not affect any other pipelines.
This change changes:
This change: has appropriate unit tests, follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
This change will: break current functionality, require additional dependencies, require a new release, other (please describe)
Motivation
Contents
Including a base class for redshift evolution models which can then be inherited by other classes to create redshift distribution.
Links to any issues or associated PRs
Testing performed
Additional notes
Co-authored-by: WuShichao <shichao.wu@aei.mpg.de>