test: cover empty/single-char repr in multiline output; fix remaining IndexError - #242
Open
koteshyelamati wants to merge 2 commits into
Open
test: cover empty/single-char repr in multiline output; fix remaining IndexError#242koteshyelamati wants to merge 2 commits into
koteshyelamati wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #240 — the tests @Jakeroid asked for, plus one more fix they surfaced.
While writing the tests I found that #240's guard fixes the string-literal check, but an empty repr() still crashes on the multiline path further down: prefix_first_line_indent_remaining() indexes lines[0] on the empty list that ''.splitlines() produces.
Changes:
icecream.py: prefix_first_line_indent_remaining() returns [prefix] when the value has no lines (empty repr).
test_icecream.py: regression test covering both an empty repr and a single-char repr under multiline output (forced via a long prefix).
Repro that still failed after fix: guard against IndexError when repr() returns empty string in formatPair() #240:
from icecream import ic
class EmptyRepr:
def repr(self): return ''
ic.configureOutput(prefix='x' * 100)
ic(EmptyRepr()) # IndexError: string index out of range
Test suite passes locally apart from two pre-existing failures unrelated to this change (test_enable_disable, test_singledispatch_argument_to_string).