-
Notifications
You must be signed in to change notification settings - Fork 1.2k
grpc-protobuf: move client exports to a submodule #2817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arjan-bal
wants to merge
4
commits into
grpc:master
Choose a base branch
from
arjan-bal:organize-protobuf-client-exports
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,23 @@ | |
| * | ||
| */ | ||
|
|
||
| //! Types and call builders for client-side RPCs. | ||
| //! | ||
| //! # Basic usage | ||
| //! | ||
| //! There are four basic RPC (Remote Procedure Call) types and a corresponding | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: move the definition of the term to the first use. |
||
| //! call builder for each. | ||
| //! | ||
| //! * Unary: [`UnaryCallBuilder`] | ||
| //! * Client Streaming: [`ClientStreamingCallBuilder`] | ||
| //! * Server Streaming: [`ServerStreamingCallBuilder`] | ||
| //! * Bidirectional Streaming: [`BidiCallBuilder`] | ||
| //! | ||
| //! Each call builder implements [`CallBuilder`] which can be used to configure | ||
| //! the call. Each one also provides an [`IntoFuture`] implementation to | ||
| //! actually begin the call. See the documentation for each type for additional | ||
| //! usage information. | ||
|
|
||
| use std::marker::PhantomData; | ||
| use std::time::Duration; | ||
| use std::time::Instant; | ||
|
|
@@ -49,10 +66,15 @@ use crate::Status; | |
| use crate::private::Internal; | ||
| use crate::trailers_conv::status_from_trailers; | ||
|
|
||
| pub(crate) mod bidi; | ||
| pub(crate) mod client_streaming; | ||
| pub(crate) mod server_streaming; | ||
| pub(crate) mod unary; | ||
| mod bidi; | ||
| mod client_streaming; | ||
| mod server_streaming; | ||
| mod unary; | ||
|
|
||
| pub use bidi::*; | ||
| pub use client_streaming::*; | ||
| pub use server_streaming::*; | ||
| pub use unary::*; | ||
|
|
||
| /// Allows sending streaming RPC protobuf request messages. | ||
| /// | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,20 +28,9 @@ | |
| //! [`protoc-gen-rust-grpc`](https://docs.rs/protoc-gen-rust-grpc). See our | ||
| //! [Quick Start Guide](docs/languages/rust/quickstart/) for more information. | ||
| //! | ||
| //! ## Basic usage | ||
| //! # Modules | ||
| //! | ||
| //! There are four basic RPC (Remote Procedure Call) types and a corresponding | ||
| //! call builder for each. | ||
| //! | ||
| //! * Unary: [`UnaryCallBuilder`] | ||
| //! * Client Streaming: [`ClientStreamingCallBuilder`] | ||
| //! * Server Streaming: [`ServerStreamingCallBuilder`] | ||
| //! * Bidirectional Streaming: [`BidiCallBuilder`] | ||
| //! | ||
| //! Each call builder implements [`CallBuilder`] which can be used to configure | ||
| //! the call. Each one also provides an [`IntoFuture`] implementation to | ||
| //! actually begin the call. See the documentation for each type for additional | ||
| //! usage information. | ||
| //! * [`client`] - Types and call builders for client-side RPCs | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same nit here: |
||
|
|
||
| use std::any::TypeId; | ||
|
|
||
|
|
@@ -58,14 +47,9 @@ use protobuf::MutProxied; | |
| use protobuf::Proxied; | ||
| use protobuf::Serialize; | ||
|
|
||
| mod client; | ||
| pub mod client; | ||
| mod status; | ||
| mod trailers_conv; | ||
| pub use client::bidi::*; | ||
| pub use client::client_streaming::*; | ||
| pub use client::server_streaming::*; | ||
| pub use client::unary::*; | ||
| pub use client::*; | ||
| pub use status::*; | ||
|
|
||
| /// Implements [`SendMessage`] for protobuf message views. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super-nit: there isn't really a thing that is a "client-side RPC". I'd probably do:
//! Client-side types and call builders for RPCs (Remote Procedure Calls).