Enable UDS tests on Windows - #828
Conversation
|
|
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
|
Oh, I was hoping CI would run tests on Windows, but that doesn't seem to be the case. I can try to run locally. (I have tested this, but in a complete application) |
|
I added a second commit, necessary to fix the tests (Windows doesn't like to remove directories when files are still in use). Flutter 3.41.0 (Dart 3.11.0): Flutter 3.38.10 (Dart 3.10.9): |
|
CI is red due to google/googleapis.dart#746, will have to wait for resolution of that first. |
|
(I also updated the README, thought it'd be nice to mention 3.11.0 is needed for UDS support on Windows) |
|
oh nice, I'll have a look at the CI failures |
109af82 to
198752a
Compare
|
https://github.com/grpc/grpc-dart/actions/runs/27000163712/job/80522388710?pr=828
I tested locally (same dart SDK) and it seems to be a flake... 1/20 so far... |
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
It is running them - or what do you mean? |
CI ended up running yes! I think something else was broken at the time. |
AF_UNIX support landed in Dart SDK 3.11.0, so the Windows skip is no longer needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
These two UDS tests called server.shutdown() without awaiting it, so the testUds tearDown could start deleting the temp directory while the server was still asynchronously unlinking the socket file inside it. On Windows this races and throws PathNotFoundException during teardown. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
198752a to
1ba1b46
Compare
AF_UNIX support landed in Dart SDK 3.11.0 (Flutter 3.41.0), so the
Windows skip in
testUdsis no longer needed.Closes #735