Skip to content

Skip handling when handler is closed to prevent processing on canceled calls #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HyprUsr wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −0
Open

Skip handling when handler is closed to prevent processing on canceled calls #820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/src/server/handler.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ class ServerHandler extends ServiceCall {
// -- Idle state, incoming data --

void _onDataIdle(GrpcMessage headerMessage) async {
if (isCanceled) return;
onDataReceived?.add(null);
if (headerMessage is! GrpcMetadata) {
_sendError(GrpcError.unimplemented('Expected header frame'));
Expand Down Expand Up @@ -276,6 +277,7 @@ class ServerHandler extends ServiceCall {
// -- Active state, incoming data --

void _onDataActive(GrpcMessage message) {
if (isCanceled) return;
if (message is! GrpcData) {
final error = GrpcError.unimplemented('Expected request');
_sendError(error);
Expand Down Expand Up @@ -316,6 +318,7 @@ class ServerHandler extends ServiceCall {
// -- Active state, outgoing response data --

void _onResponse(dynamic response) {
if (isCanceled) return;
try {
final bytes = _descriptor.serialize(response);
if (!_headersSent) {
Expand All @@ -336,10 +339,12 @@ class ServerHandler extends ServiceCall {
}

void _onResponseDone() {
if (isCanceled) return;
sendTrailers();
}

void _onResponseError(Object error, StackTrace trace) {
if (isCanceled) return;
if (error is GrpcError) {
_sendError(error, trace);
} else {
Expand Down Expand Up @@ -443,6 +448,7 @@ class ServerHandler extends ServiceCall {
}

void _onDoneExpected() {
if (isCanceled) return;
if (!(_hasReceivedRequest || _descriptor.streamingRequest)) {
final error = GrpcError.unimplemented('No request received');
_sendError(error);
Expand Down