Skip to content

Item Checkin/Checkout: Fixed #19174 - Allow file uploads - #19189

Closed
snipe wants to merge 9 commits into
developfrom
upload-files-on-checkout-and-checkin
Closed

snipe wants to merge 9 commits into
developfrom
upload-files-on-checkout-and-checkin

Use import

3fc1413
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Jun 15, 2026 in 0s

7 new issues (0 max.) of at least severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 6
- Added 7
           

Complexity increasing per file
==============================
- app/Http/Controllers/Api/AssetsController.php  2
- app/Http/Controllers/Licenses/LicenseCheckoutController.php  3
- app/Http/Controllers/Components/ComponentCheckoutController.php  1
- app/Http/Controllers/Consumables/ConsumableCheckoutController.php  1
- app/Http/Controllers/Accessories/AccessoryCheckoutController.php  1
- app/Http/Controllers/Assets/AssetCheckoutController.php  1
- tests/Feature/Checkins/Api/FileUploadOnCheckinTest.php  5
- tests/Feature/Checkins/Ui/FileUploadOnCheckinTest.php  5
- tests/Feature/Checkouts/Api/FileUploadOnCheckoutTest.php  6
- tests/Feature/Checkouts/Ui/FileUploadOnCheckoutTest.php  6
         

See the complete overview on Codacy

Annotations

Check warning on line 1115 in app/Http/Controllers/Api/AssetsController.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/Http/Controllers/Api/AssetsController.php#L1115

The method checkin() has an NPath complexity of 864. The configured NPath complexity threshold is 200.

Check warning on line 295 in app/Http/Controllers/Api/ComponentsController.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/Http/Controllers/Api/ComponentsController.php#L295

The method checkout() has an NPath complexity of 296. The configured NPath complexity threshold is 200.

Check warning on line 286 in app/Http/Controllers/Api/ConsumablesController.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/Http/Controllers/Api/ConsumablesController.php#L286

The method checkout() has an NPath complexity of 576. The configured NPath complexity threshold is 200.

Check warning on line 282 in app/Http/Controllers/Api/LicensesController.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/Http/Controllers/Api/LicensesController.php#L282

The method checkout() has 106 lines of code. Current threshold is set to 100. Avoid really long methods.

Check warning on line 282 in app/Http/Controllers/Api/LicensesController.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/Http/Controllers/Api/LicensesController.php#L282

The method checkout() has an NPath complexity of 5632. The configured NPath complexity threshold is 200.

Check warning on line 59 in app/Http/Controllers/Licenses/LicenseCheckinController.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/Http/Controllers/Licenses/LicenseCheckinController.php#L59

Avoid unused parameters such as '$backTo'.

Check warning on line 59 in app/Http/Controllers/Licenses/LicenseCheckinController.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/Http/Controllers/Licenses/LicenseCheckinController.php#L59

The method store() has an NPath complexity of 576. The configured NPath complexity threshold is 200.