storage: add cert tests - #36
Merged
Merged
Conversation
new error checking is more strict (though still not ideal)
|
* refactor some other inuse checks to use a transaction * minor test print updates
* update some get tests to wrong casing
* refactor CertExtension to use proper json interfaces and get business logic out of storage * rename time file
* make b64 key post and putable (with validation) * refactor to leverage common func * modify put payload to use time.Time * rename PutCertUpdate function * rename PutCertUpdatedAt function
* refactor some time types to time.Time * rename some funcs for clarity *
* also rename helpers_test func
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.